| 1.1 |
|
With Edit -> Cut Rows causes a assertion failure (testing in Debug)
4
|
|
Assertion failed in file SlotGUIUtils.cpp at line 2857: "("The specified Slot doesn't have a User Format", 0)" |
|
| |
I'm still trying to reproduce this. I haven't seen this assertion failure yet. |
| 1.2 |
8-23 |
Opening a slot that is already shown in the viewer re-orders the columns to put that one on the right. It should just open the viewer and select that column without re-ordering. |
| |
Will do. (That is, actually, what we do in this different operation: Dragging a "redundantly opened" slot into the viewer, i.e. when that slot is already present in the viewer). |
| |
Done. Also, in the course of selecting the added slots, for no good reason, the top-left visible cell was always becoming the new Current Cell. This has been changed to always set the current cell to one in the newly selected display columns.
|
| 1.3 |
|
I feel like we need some way to make this slot viewer look different than the Open Slot dialog. The difference is too subtle. I don't have any good ideas yet, but maybe some coloring. |
| |
For discussion, here is a comparison of the two dialogs: ViewerSlotDlgComparison.png |
| 1.4 |
8-23 |
Does it always grow when you add slots? Can we put an upper limit on the width? Once you've resized it and then add a new slot, it grows to fit the new slot. |
| |
The auto width resizing seems good to me. Implicitly, that's currently limited to the screen width. We could implement a more complicated algorithm. Here are a few options.
- Auto width resizing is limited to a fixed maximum, e.g. 700 pixels.
- Auto width resizing is limited to the widest width the user has manually adjusted the window to (defaulted to, e.g. 700 pixels).
- Auto width resizing is disabled once the user has manually adjusted its width. (I don't recommend this sort of algorithm -- I think it would seem confounding to users).
|
| |
The first (simplest) algorithm was implemented. When an automatic width is applied to the Slot Viewer dialog, that automatic width will not exceed the value defined by the following symbol in Q3GUI/SlotQtDlg.cpp:
static const int SLOT_VIEWER_MAX_AUTO_WIDTH (700); // 7.2: 700 |
| 1.5 |
8-23 |
We need to decide where we want the following slots to open:
- Series Slots with Periodic Input
- Series Expression Slots
- Multi-slots with multiple columns.
|
| |
The currently implemented behavior for these, respectively, is:
- Slot Viewer -- minimally NEEDS A FIX. It needs to be read-only if it's in "Periodic" input mode.
- Slot Viewer (series column only -- ready only, shown as crosshatched)
- Slot Viewer -- only first column (computed Sum) shown.
|
| |
I addressed the FIX noted in item #1, above. Series Slots with Periodic Input (for which only the series data is shown in the Slot Viewer) need to be READ ONLY when the slot is in Periodic Input mode.
To address this problem, a new 'dynamicReadOnly()' predicate was added to the Q3GUI/SlotQDlgSlotData class. Formerly, the _readOnly data member was directly accessed by "friend" clients, including the SlotDataTableModel class. Now that class uses this new predicate, which, in the case of Series Slots with Periodic Input, in the Slot Viewer context, checks the SeriesSlot's "alt input mode" state. |
| 1.6 |
8-23 |
Changing the timestep size of a custom slot shown on the viewer works, but then removes it from the viewer and nothing is shown. Removing from the viewer is OK, but should show the slot in an open slot dialog. |
| |
Can do. (I didn't bother with this because changing the timestep size of a series slot seemed like an unsual thing to be doing, relative to the ephemeral use of the Slot Viewer). |
| |
I ATTEMPTED to implement this behavior -- i.e. SHOWING the automatically removed slot in its own dialog, as a result of changing the slot's series timestep size. See method:
SlotQtDlg::slotViewer_removeUnsupportedSlots(). A comment added to this method describes the problem which prevents the added code from having the desired effect:
// ***********************************************************
// *** Show Removed Slots in their own Open Slot Dialogs ***
// ***********************************************************
// Note [Phil, RW 7.2, 8-2017]: This is the right idea (and was
// explicitly requested by David in the Slot Viewer development review).
// But, in the larger context in which this is relevant, it doesn't have
// an effect because of a pretty funny reason. The Slot's Time Series
// Configuration dialog (and not necessarily the Open Slot dialog) is
// (typically) already open -- and THAT'S the "Slot's" dialog which is
// found when we attempt to open "the" slot's dialog. I am checking in
// this code, because it is "correct". But the effect would have to be
// fixed at that other level.
const Date_Time when = getDateTime();
QList<BaseRWDlg*> newDlgs = QGui::openSlots (removedSlotColList, &when);
newDlgs; // (avoid compilation warning)
|
down to the column heading row?
