CADSWES Maintenance Accomplishment Report Compilation -- May 2017
Phil Weinstein, edit 7-14-2017 (a).

May 2017 Maintenance Highlights:

1. Substantial completion of RiverWare Visual Studio (compiler) upgrade from VS 2010 to VS 2013.
2. RiverWare 7.0.7 Patch Release (5-11-2017).
3. RiverWare 7.1 Development Snapshot with VS2010 to VS2013 upgrade.
4. Twelve (12) completed bug fixes.
5. Ongoing: Monitoring and maintaining daily RiverWare regression tests.
6. Ongoing: Installation Process and Licensing development and administration.

Report contributors:

• Substantial content from: Jessica, Bill, Robynn, Phil, David.
• Bug fix items from: Patrick (5), David (3), Phil (2), Tim (1).
• Indicated that they had no maintenance accomplishments to report this month: Mitch.

(II.A) Releases, Patches and Snapshots

The following releases were generated this month:

• RiverWare 7.0.7 Patch Release (5-11-2017).
• RiverWare 7.1 Development Snapshot with VS2010 to VS2013 upgrade.

RiverWare 7.0.7 (5-11-2017) Release Notes:

(II.B) Software Updates, Bug fixes (not associated with new development)

The following twelve bugs were fixed:

1. Bug 5541: File association after install of 6.5 and 6.5.1.
2. Bug 5947: The RPL function GetMinSpillGivenInflowRel could calculate incorrect spill values when Unregulated Flow 2 and 3 are used.
3. Bug 5952: crash when loading a model in geospatial view
4. Bug 5956: POSAT crash when viewing solution info for a goal that is modified after the run
5. Bug 5959: On the power reservoir, the Plant Power Table With Units lookup was improved to not error in certain cases. (Neumann)
6. Bug 5961: Within the Soil Moisture methods on the Water User object, negative Soil Moisture could be computed. This led to a failure in water quality salinity methods. (Neumann)
7. Bug 5962: Keyboard shortcut (Alt+E) fails for expression series slot.  On the expression slot, the "Evaluate" shortcut key was changed to F9 due to the previous shortcut conflicting with other operations.
8. Bug 5958: Creating SCT for Integer Indexed Series Slots didn't always work. 
9. Bug 5972: optimization error "simplifying expression".
    
10. Unfiled Bug: Under some conditions, RiverWare was logging a large number of errors with the Windows event management system. These were triggered by certain exception types that do not represent errors, so these are no longer reported to the event manager.
11. Unfiled Bug: Borg-RW: Incorrect creation of ascending/descending table column inputs.
12. Unfiled Bug: Debugged optimization "infeasibility" in the Visual Studio 2013 build with a new CPLEX library version.

Significant work was done on the following bug:

• Bug 5972: arithmetic error while simplifying an optimization constraint

Code Refactoring:

The Slope Power Reservoir slope storage calculation was refactored for improved maintenance, readability, and understanding.

Added BCM (Billion Cubic Meters) and related flow units:

Similar to TCM (thousand cubic meters) and MCM (million cubic meters), the following units have been added for RiverWare 7.1. This applies to both conventional units (e.g. used on slots) and RPL units. These definitions are expressed in the "units" and "RplUnits" text files deployed with the RiverWare executable.

• BCM -- Billion Cubic Meters
• BCM/day -- Billion Cubic Meters per Day
• BCM/month -- Billion Cubic Meters per Month
• BCM/year -- Billion Cubic Meters per Year

Uniform Snapshot Camera-Themed Icons:

RiverWare 7.0 and prior versions had inconsistent graphical "motifs" to refer to Snapshot-object-related functions and objects, making use of essentially two, unrelated "camera" graphics. A new 24x24 pixel "Snapshot Manager" camera icon, e.g. for the Workspace toolbar, is now a graphic component within the 40x40 pixel Snapshot-Object (special Data Object) simulation object icons. This was done for RiverWare 7.1.

(II.C) Development tool improvements; issue tracking software; modelcomp

RiverWare Visual Studio Upgrade (from VS 2010 to VS 2013):

Upgrading RiverWare to Microsoft Visual Studio 2013 (C++ compiler and integrated development environment) has been an ongoing project, with work spanning several months. Part of the effort includes upgrading to new versions of 3rd party libraries, either downloading libraries as precompiled binaries or building libraries from source.

There are eighteen 3rd party libraries which RiverWare uses and there are dependencies between the libraries, Visual Studio and Windows which can sometimes make the path forward difficult, if not impossible. For example, we would prefer to use VS 2015 (or perhaps VS 2017) but Oracle Client requires VS 2013, so Oracle Client is preventing us from moving beyond VS 2013. Furthermore, VS 2013 isn't supported on Windows 10, so Oracle Client is preventing us from moving beyond Windows 8.1, and Microsoft has stated that PCs based on new CPUs will require Windows 10, so Oracle Client may constrain our ability to buy new PCs. This is but one example of the types of problems which arise with RiverWare's complex development environment. Navigating the dependencies is difficult but necessary to ensure RiverWare's future as a supportable product.

In May, focus turned to the 32-bit development environment. The 32-bit 3rd party libraries were either downloaded as precompiled binaries or built from source. Also in May a few "straggler" issues were resolved. By the end of May the Visual Studio 2013 port was for the most part complete – there were working 64-bit and 32-bit release and debug executables available to begin testing.

May accomplishments include:

• A 32-bit Visual Studio 2013 environment was created and configured in addition to the existing 64-bit environment.
• Visual Studio 2013-compatible versions of all required 3rd party libraries were built from source code or acquired in binary form.
• Regression tests passed fully for the 64-bit version.
• A 64-bit snapshot install file was generated.
• Manual testing of the 64-bit by the RiverWare development team began, using an assigned-task test plan. This testing continuied into June.
• The install procedure for the Visual Studio 2013 software was developed and tested for use on in-house development machines.  Both the old and the new version will operate simultaneously.
• The RiverWare library install process for in-house development machines was upgraded to support Visual Studio 2013, documented, and made available for immediate use.
• Debugged optimization "infeasibility" in the Visual Studio 2013 build with a new CPLEX library version.

The following document describes the process of acquiring and building RiverWare's 3rd party libraries:

• Building RiverWare's required libraries and auxiliary programs.
  R:\windows\config\Documents\RiverWareDevEnv_2017_06.docx

Adoption of OIT BitBucket Server repository hosting service:

CADSWES moved the internally hosted git repository for the RiverWare source code to the BitBucket Server hosting supported by OIT.

(II.D) Enhancements or changes to regression tests (not part of development tasks)

The regression tests continue to be maintained on a daily basis. This involves updating the regression tests to exercise new developments in the code. Also, as new code is added to the development area, the model comparisons performed in the nightly regression tests usually show differences (for example, because a new method category may have been added). When this occurs, the regression tests need to be updated to reflect the current state of the development area so model comparisons do not fail. In addition, every week, the daily history of each regression test is analyzed to determine if the run time or model size has significantly changed because of new development.

(II.E) Download, Install and Release Processes

• Created a new InstallShield testing project file for generating the 7.1 snapshot release built with VS2013. Set up the directory hierarchy for holding the snapshot release files used by IS project files.
• Bug 5541: File association after install of 6.5 and 6.5.1. This has been fixed. Applied the changes to all IS project files and updated the details in internal release document.
• Updated the document "RiverWare Floating License Troubleshooting Checklist."
• Switched the builds/prerel/release GIT source areas from Alamosa to the OIT BitBucker server hosted service.
• Pending: Bug 5893: Uninstall leaves folder "servers" behind. No progress this month.

(II.F) Updates to license software/procedures

• Maintaining RiverWare licenses for internal development systems. This is an ongoing task.
• Prepared the USACE license record report for Edie.

(II.G) Updates to download/install/configure user documentation

None reported for May 2017.

(II.H) Modification to Web pages for downloads and installs

None reported for May 2017.

--- (end) ---