Project: USACE ABQ 5.11: Output Canvas Items on Workspace views
Phil's code review for Robynn, 5-18-2017 (a) -- IN PROGRESS (HIT REFRESH) -- see also Phil's project notes.
Status | Description | |
(1) | New Output Canvas Settings ... Change from "True/False" to "Yes/No". (This shouldn't break serialization, the rwBoolSetting's state is independent of display text, I'm pretty sure).
|
|
Status | Description | |
(1) | The "Lock/Unlock Icon Positions" toggle needs to apply also to Output Canvas items on the Workspace. |
|
(2) | Don't show Output Canvas Object Icons on the Workspace. |
Status | Description | |
(1) | done 5-18 |
I'd rather see this static method coded as a mutable instance method: OLD: static void copyWorkspaceCoordinates(OutputCanvasConfig*, OutputCanvasConfig*); Short of that, at least make the 'source' parameter const. |
(2) | done 5-18 |
My general preference is that these have const reference parameters. void setSimCoordinates(QPointF); |
(3) | I really like the formulation of these virtual methods. Since this will be evolving over time (and since there is room), I'd annotate these with the RW version with which the value was last established -- i.e. the added comment in this example: OLD: bool canBeAddedToWorkspace() const override { return false; } |
|
(4) | done 5-18 |
These methods want to be 'const'. QPointF getSimCoordinates() {return _simCoords;} |
---