----------------------------------------------------------------
Comparison of setting Qt::WA_DeleteOnClose between RiverWare 6.3 
and current RiverWare 6.5 development. [1-16-2014] [Gnats 5437].
----------------------------------------------------------------

Lines with "<"  RiverWare 6.3, before relevant Qt4 porting work
Lines with ">"  RiverWare 6.5, after relevant Qt4 porting work

The only change from 'false' to 'true' was in SimpleTimeRangeEditorDlg.cpp.
But there are many new places where this attribute is now set to 'true'
where it had not been set before. And the default is 'false' (confirmed
empirically), so there is still potentially a problem with QDialog instances 
instantiated on the stack.


0a1
> DbDmi/DatasetMgrDlg.cpp:          setAttribute(Qt::WA_DeleteOnClose, true);
3a5,6
> DbDmi/NameMapMgrDlg.cpp:          setAttribute(Qt::WA_DeleteOnClose, true);
> Q3GUI/AboutDlg.cpp:               _instance->setAttribute (Qt::WA_DeleteOnClose, true);
4a8,14
> Q3GUI/AboutDlg.cpp:               setAttribute (Qt::WA_DeleteOnClose, true);
> Q3GUI/AccountGroupDlg.cpp:        setAttribute (Qt::WA_DeleteOnClose, true);
> Q3GUI/AnnoGroupEditor.cpp:        _instance->setAttribute (Qt::WA_DeleteOnClose, true);
> Q3GUI/AnnoGroupEditor.cpp:        setAttribute (Qt::WA_DeleteOnClose, true);
> Q3GUI/AnnoGroupMgrDlg.cpp:        setAttribute (Qt::WA_DeleteOnClose, true);
> Q3GUI/AnnoGroupMgrDlg.cpp:        _instance->setAttribute (Qt::WA_DeleteOnClose, true);
> Q3GUI/AnnoGroupMgrDlg.cpp:        setAttribute (Qt::WA_DeleteOnClose, true);
8a19,20
> Q3GUI/DiagCfgDlg.cpp:             setAttribute (Qt::WA_DeleteOnClose, true);
> Q3GUI/DiagMgrDlg.cpp:             dlgToClose->setAttribute (Qt::WA_DeleteOnClose, true);
9a22,29
> Q3GUI/DiagOutputColorLegend.cpp:  setAttribute (Qt::WA_DeleteOnClose, true);
> Q3GUI/DiagOutputDockWindow.cpp:   setAttribute (Qt::WA_DeleteOnClose, true);
> Q3GUI/DiagOutputDockWindow.cpp:   setAttribute (Qt::WA_DeleteOnClose, true);
> Q3GUI/DiagOutputMenuItems.cpp:    _diagOutputDockWindow->setAttribute (Qt::WA_DeleteOnClose, true);
> Q3GUI/DiagOutputQMainWindow.cpp:  setAttribute (Qt::WA_DeleteOnClose, true);
> Q3GUI/DiagOutputQMainWindow.cpp:  setAttribute (Qt::WA_DeleteOnClose, true);
> Q3GUI/DiagOutputQMainWindow.cpp:  setAttribute (Qt::WA_DeleteOnClose, true);
> Q3GUI/DiagOutputWidget.cpp:       _colorLegendDlg->setAttribute (Qt::WA_DeleteOnClose, true);
19a40,41
> Q3GUI/GusSelector.cpp:            _dlg->setAttribute (Qt::WA_DeleteOnClose, true);
> Q3GUI/GusSelector.cpp:            _dlg->setAttribute (Qt::WA_DeleteOnClose, true);
20a43
> Q3GUI/MultiObjMethSelConfirmDlg.cpp: setAttribute (Qt::WA_DeleteOnClose, true);
25c48,51
< Q3GUI/NoteGroupMgrDlg.cpp:        setAttribute (Qt::WA_DeleteOnClose);
--
> Q3GUI/NoteGroupMgrDlg.cpp:        setAttribute (Qt::WA_DeleteOnClose, true);
> Q3GUI/OpenObjectDlg.cpp:          setAttribute (Qt::WA_DeleteOnClose, true);
> Q3GUI/OrnamentEditorDlg.cpp:      setAttribute (Qt::WA_DeleteOnClose, true);
> Q3GUI/OrnamentEditorDlg.cpp:      setAttribute (Qt::WA_DeleteOnClose, true);
26a5
> Q3GUI/OutputConfigDlg.cpp:        setAttribute (Qt::WA_DeleteOnClose, true);
27a55
> Q3GUI/PlotDialog.cpp:             dlg->setAttribute (Qt::WA_DeleteOnClose, true);
28a57
> Q3GUI/PlotDialog.cpp:             setAttribute (Qt::WA_DeleteOnClose, true);
35a65
> Q3GUI/QGui.cpp:                   ws->setAttribute (Qt::WA_DeleteOnClose, true);  
41a72,73
> Q3GUI/ScalarSlotDlg.cpp:          setAttribute (Qt::WA_DeleteOnClose, true);
> Q3GUI/ScalarSlotDlg.cpp:          setAttribute (Qt::WA_DeleteOnClose, true);
55a88,103
> Q3GUI/SlotDataTableModel.cpp:     _floatValueEditor->setAttribute (Qt::WA_DeleteOnClose, true);
> Q3GUI/SlotDataTableModel.cpp:     _floatValueEditor->setAttribute (Qt::WA_DeleteOnClose, true);
> Q3GUI/SlotDataTableModel.cpp:     _floatValueEditor->setAttribute (Qt::WA_DeleteOnClose, true);
> Q3GUI/SlotDataTableModel.cpp:     _floatValueEditor->setAttribute (Qt::WA_DeleteOnClose, true);
> Q3GUI/SlotDataTableModel.cpp:     _floatValueEditor->setAttribute (Qt::WA_DeleteOnClose, true);
> Q3GUI/SlotDataTableModel.cpp:     _periodTimeSelector->setAttribute (Qt::WA_DeleteOnClose, true);
> Q3GUI/SlotDataTableModel.cpp:     _periodTimeSelector->setAttribute (Qt::WA_DeleteOnClose, true);
> Q3GUI/SlotDataTableModel.cpp:     _periodTimeSelector->setAttribute (Qt::WA_DeleteOnClose, true);
> Q3GUI/SlotDataTableModel.cpp:     _periodTimeSelector->setAttribute (Qt::WA_DeleteOnClose, true);
> Q3GUI/SlotDataTableModel.cpp:     _periodTimeSelector->setAttribute (Qt::WA_DeleteOnClose, true);
> Q3GUI/SlotDataTableModel.cpp:     fed->setAttribute (Qt::WA_DeleteOnClose, true);
> Q3GUI/SlotDataTableModel.cpp:     impDlg->setAttribute (Qt::WA_DeleteOnClose, true);
> Q3GUI/SlotDataTableModel.cpp:     pts->setAttribute (Qt::WA_DeleteOnClose, true);
> Q3GUI/SlotDataTableModel.cpp:     xDlg->setAttribute (Qt::WA_DeleteOnClose, true);
> Q3GUI/SlotDataTableModel.cpp:     fed->setAttribute (Qt::WA_DeleteOnClose, true);
> Q3GUI/SlotDataTableModel.cpp:     pts->setAttribute (Qt::WA_DeleteOnClose, true);
66d113
< Q3GUI/SlotQtDlg.cpp:              //--    dlg->setAttribute (Qt::WA_DeleteOnClose, true);
68,69d114
< Q3GUI/SlotQtDlg.cpp:              //--    setAttribute (Qt::WA_DeleteOnClose, true);
< Q3GUI/SlotQtDlg.cpp:              //--    setAttribute (Qt::WA_DeleteOnClose, true);
74a120,121
> Q3GUI/SlotTimeseriesRangeQtDlg.cpp: setAttribute (Qt::WA_DeleteOnClose, true);
> Q3GUI/SlotTimeseriesRangeQtDlg.cpp: setAttribute (Qt::WA_DeleteOnClose, true);
78a126
> Q3GUI/StatTableSlotDlg.cpp:       dlg->setAttribute (Qt::WA_DeleteOnClose, true);
84a133,139
> Q3GUI/UnitConvertDlg.cpp:         _instance->setAttribute (Qt::WA_DeleteOnClose, true);
> Q3GUI/UnitConvertDlg.cpp:         setAttribute (Qt::WA_DeleteOnClose, true);
> Q3GUI/UnitConvertDlg.cpp:         setAttribute (Qt::WA_DeleteOnClose, true);
> Q3GUI/Workspace.cpp:              dlg->setAttribute (Qt::WA_DeleteOnClose, true);
> Q3GUI/Workspace.cpp:              _nameMapMgrDlg->setAttribute (Qt::WA_DeleteOnClose, true);
> Q3GUI/Workspace.cpp:              _fileInfoDlg->setAttribute (Qt::WA_DeleteOnClose, true);
> Q3GUI/Workspace.cpp:              setAttribute (Qt::WA_DeleteOnClose, true);
87a143,149
> QtAccounting/AccountingSysConfigDlg.cpp:     oldInstance->setAttribute (Qt::WA_DeleteOnClose, true);
> QtAccounting/AcctCellColorLegend.cpp:        _instance->setAttribute (Qt::WA_DeleteOnClose, true);
> QtAccounting/AcctCellColorLegend.cpp:        setAttribute (Qt::WA_DeleteOnClose, true);
> QtAccounting/AcctCellColorLegend.cpp:        setAttribute (Qt::WA_DeleteOnClose, true);
> QtAccounting/AcctSubordinationViewerDlg.cpp: closeDlg->setAttribute (Qt::WA_DeleteOnClose, true);
> QtAccounting/AcctSubordinationViewerDlg.cpp: setAttribute (Qt::WA_DeleteOnClose, true);
> QtAccounting/AcctSubordinationViewerDlg.cpp: setAttribute (Qt::WA_DeleteOnClose, true);
93a156,157
> QtAccounting/ExchangeCfgDlg.cpp:  setAttribute (Qt::WA_DeleteOnClose, true);
> QtAccounting/ExchangeCfgDlg.cpp:  setAttribute (Qt::WA_DeleteOnClose, true);
96a161,164
> QtAccounting/MultiAcctMethSelConfirmDlg.cpp:  setAttribute (Qt::WA_DeleteOnClose, true);
> QtAccounting/MultiAcctMethSelector.cpp: setAttribute (Qt::WA_DeleteOnClose, true);
> QtAccounting/MultiAcctMethSelector.cpp: setAttribute (Qt::WA_DeleteOnClose, true);
> QtAccounting/MultiAcctMethSelector.cpp: setAttribute (Qt::WA_DeleteOnClose, true);
98a167,173
> QtAccounting/ObjAcctSumSaveDlg.cpp: setAttribute (Qt::WA_DeleteOnClose, true);
> QtAccounting/OpenAccountDlg.cpp:  setAttribute (Qt::WA_DeleteOnClose, true);
> QtAccounting/OpenAccountDlg.cpp:  setAttribute (Qt::WA_DeleteOnClose, true);
> QtAccounting/OpenAccountDlg.cpp:  setAttribute (Qt::WA_DeleteOnClose, true);
> QtAccounting/OpenAccountDlg.cpp:  setAttribute (Qt::WA_DeleteOnClose, true);
> QtAccounting/QtAcctGuiMgr.cpp:    theDlg->setAttribute (Qt::WA_DeleteOnClose, true);
> QtAccounting/QtAcctGuiMgr.cpp:    theDlg->setAttribute (Qt::WA_DeleteOnClose, true);
103a179
> QtAccounting/SupplyNameFormatDlg.cpp:  setAttribute (Qt::WA_DeleteOnClose, true);
104a181,182
> QtDmi/DmiMgrDlg.cpp:              setAttribute (Qt::WA_DeleteOnClose, true);
> QtDmi/DmiMgrDlg.cpp:              setAttribute (Qt::WA_DeleteOnClose, true);
106c184
< QtRpl/RplDocConfigDlg.cpp:        setAttribute (Qt::WA_DeleteOnClose);
---
> QtRpl/RplDlgMgr.cpp:              dlg->setAttribute (Qt::WA_DeleteOnClose, true);
107a186
> QtRpl/RplDocConfigDlg.cpp:        setAttribute (Qt::WA_DeleteOnClose, true);
108a188,191
> QtRun/MultiRunControlDlg.cpp:     dlg->setAttribute (Qt::WA_DeleteOnClose, true);
> QtRun/MultiRunEditDlg.cpp:        setAttribute (Qt::WA_DeleteOnClose, true);
> QtRun/MultiRunEditDlg.cpp:        setAttribute (Qt::WA_DeleteOnClose, true);
> QtRun/OptSolutionViewer.cpp:      setAttribute(Qt::WA_DeleteOnClose);
120c203,209
< QtRun/SimpleTimeRangeEditorDlg.cpp: setAttribute (Qt::WA_DeleteOnClose, false);
---
> QtRun/SimpleTimeRangeEditorDlg.cpp: setAttribute (Qt::WA_DeleteOnClose, true);
> QtRun/SyncControlDlg.cpp:         setAttribute (Qt::WA_DeleteOnClose, true);
> QtRun/SyncControlDlg.cpp:         _instance->setAttribute (Qt::WA_DeleteOnClose, true);
> QtRun/SyncControlDlg.cpp:         setAttribute (Qt::WA_DeleteOnClose, true);
> QtRun/SyncControlDlg.cpp:         setAttribute (Qt::WA_DeleteOnClose, true);
> QtSCT/SctDialog.Handlers.cpp:     _diagOutDockWindow->setAttribute (Qt::WA_DeleteOnClose, true);
> QtSCT/SctDialog.Handlers.cpp:     _sctTimestepAggCfgDialog->setAttribute (Qt::WA_DeleteOnClose, true);
121a211,223
> QtSCT/SctDialog.cpp:              _aggTimeHorzView->setAttribute (Qt::WA_DeleteOnClose, true);
> QtSCT/SctDialog.cpp:              _aggTimeVertView->setAttribute (Qt::WA_DeleteOnClose, true);
> QtSCT/SctDialog.cpp:              _noAggTimeHorzView->setAttribute (Qt::WA_DeleteOnClose, true);
> QtSCT/SctDialog.cpp:              _noAggTimeVertView->setAttribute (Qt::WA_DeleteOnClose, true);
> QtSCT/SctDialog.cpp:              _sctCfgDlg->setAttribute (Qt::WA_DeleteOnClose, true);
> QtSCT/SctDialog.cpp:              _sctCfgDlg->setAttribute (Qt::WA_DeleteOnClose, true);
> QtSCT/SctDialog.cpp:              _sctCfgDlg->setAttribute (Qt::WA_DeleteOnClose, true);
> QtSCT/SctDialog.cpp:              _sctCfgDlg->setAttribute (Qt::WA_DeleteOnClose, true);
> QtSCT/SctDialog.cpp:              _sctClipboardExportDlg->setAttribute (Qt::WA_DeleteOnClose, true);
> QtSCT/SctDialog.cpp:              _sctFindSlotDlg->setAttribute (Qt::WA_DeleteOnClose, true);
> QtSCT/SctDialog.cpp:              _sctLabelFnDlg->setAttribute (Qt::WA_DeleteOnClose, true);
> QtSCT/SctDialog.cpp:              _sctTimestepAggCfgDialog->setAttribute (Qt::WA_DeleteOnClose, true);
> QtSCT/SctDialog.cpp:              findDlg->setAttribute (Qt::WA_DeleteOnClose, true);
122a225,227
> QtSCT/SctDialog.cpp:              setAttribute (Qt::WA_DeleteOnClose, true);
> QtSCT/SctManager.cpp:             dlg->setAttribute (Qt::WA_DeleteOnClose, true); 
> QtSCT/SctManager.cpp:             dlg->setAttribute (Qt::WA_DeleteOnClose, true); 
124a230,233
> QtSCT/SctView.cpp:                impDlg->setAttribute (Qt::WA_DeleteOnClose, true);
> QtUtils/ActionListMgrDlg.cpp:     _listDialogs[i]->setAttribute(Qt::WA_DeleteOnClose, true);
> QtUtils/ActionListMgrDlg.cpp:     listDlg->setAttribute(Qt::WA_DeleteOnClose);
> QtUtils/ActionListMgrDlg.cpp:     setAttribute(Qt::WA_DeleteOnClose, false);
127c236,237
< QtUtils/ClipboardImportDlg.cpp:   setAttribute (Qt::WA_DeleteOnClose);
---
> QtUtils/ClipboardImportDlg.cpp:   _priorInstance->setAttribute (Qt::WA_DeleteOnClose, true);
> QtUtils/ClipboardImportDlg.cpp:   setAttribute (Qt::WA_DeleteOnClose, true);
139a250,251
> QtUtils/DisplayCompressPanel.cpp: _floatValEditor->setAttribute (Qt::WA_DeleteOnClose, true);
> QtUtils/DisplayCompressPanel.cpp: _floatValEditor->setAttribute (Qt::WA_DeleteOnClose, true);
160a273,275
> QtUtils/SaveModelConfirmDlg.cpp:  setAttribute (Qt::WA_DeleteOnClose, true);
> QtUtils/SaveModelConfirmDlg.cpp:  setAttribute (Qt::WA_DeleteOnClose, true);
> QtUtils/SaveModelConfirmDlg.cpp:  setAttribute (Qt::WA_DeleteOnClose, true);

---