Edie,

Two of our 15 Accounting regression tests DO show this crash.  (This isn't just an old model thing).

    accountingRules (274 daily timesteps)
    ... the similar accountingHeronInflow model does not crash (also 274 daily timesteps)
    WaterRightsTests

The other Accounting regression tests also do not show the crash:

    urgwomPlanning does not show the crash, but it's only a 30 daily timestep model. 
    10 variations of the "wra*" -- only 10 daily timesteps. 


Debug builds show two areas of assertion failures.  The fix I implemented for the first is necessary to get to the second:

    In the process of the Link Manager's "checkAllSharing" method, which starts or stops series slot series sharing (as appropriate), the SeriesSlot method which starts sharing (p_startSharingSeriesWith) forces effected MultiSlots to recompute.  That fails debug-only assertions because various linked slots may not yet have been set to the new timestep size (monthly).  I added a mechanism to conditionally refrain from forcing MultiSlot recomputations down in that SeriesSlot method, and instead return that information to the caller (LinkMgr) to perform those recomputations after all series slots have be set to the new timestep size.
     
    In the course of applying the Aggregated Inputs (the code Neil implemented), setting values an Accounting slot (which is now monthly) encounters inconsistent end-dates on the Flag series.  Enhanced debug code I created shows this data (the Flag series is missing one final timestep):

        CONSISTENCY FAILURE (Flag End);
        share 11-01-1996 00:00:00;
        flag 10-01-1996 00:00:00;
        @ slot Azotea Outlet^SanJuan.Outflow

The crash can be avoided by first re-synchronizing all slots (including Accounting, but excluding slots with a different timestep from the run) BEFORE changing the timestep size from daily to monthly.  (But this would have the effect of truncating Series Slot data after the Run Finish date).

The code changes I have in the temporary Bug3718 git branch are:

(For #1, above):

    Optional parameter (can be NULL) added to these to methods to return information about the MultiSlots needing to be recomputed:

        SeriesSlot::p_startSharingSeriesWith (SeriesSlot *other,
           QList<MultiSlotLinkSlotPair>* multiSlotLinkPairsNeedingRecomp);
        LinkMgr::checkSharing(Link *l) const (CALLED FROM LinkMgr::checkAllSharing()).

(For #2, above):

    Cleanup and enhancements to this diagnostic check method, reporting more information about Split Series inconsistency problems.  This changes are isolated within this diagnostic method:

        SeriesSlot::p_checkSplitSeriesConsistency() const

I recommend adopting these changes (in the actual trunk).

Phil