Gnats 5202: "Unable to uncheck Convergence Checking box in Run Parameter"

Source Code Analysis: "No Supply Slot Convergence Checking" Checkbox / Phil Weinstein, 4-18-2013

This checkbox in the "Rulebased Simulation Run Parameters" dialog is not hooked up to any state information. It is unconditionally checked (turned on) each time the dialog is refreshed.

There are comments in the dialog source code indicating that this checkbox should be removed. Commented out code shows that it used to -- but no longer -- sets a property on the Account Manager.

CONCLUSION: This checkbox can just be removed.

See code excerpts below.

Gnats 5202: Unable to uncheck convergence Checking box in Run Parameter
Source code analysis, Phil Weinstein, 4-18-2013.
(Bug filed: 5-24-2012; RiverWare 6.2). 

------------------------
QtRun/SimParamWidgets.ui
------------------------

 <widget class="QCheckBox" name="_supplyConvCheckBox">
  <property name="text">
   <string>No Supply Slot Convergence Checking</string>
  </property>
 </widget>

-----------------------
QtRun/QtSimParamDlg.cpp
-----------------------

  // *********************************************
  // *** Checkbox Visibility and Value Setting ***
  // *********************************************

  In private method: void QtSimParamDlg::updateIter (bool disabled) ...
  
  // the accounting max iteration and supply convergence are only
  // visible for accounting.

  RunType runType(_ri->getType());
  if (runType == RT_ACCOUNTING ||
      runType == RT_SIM_ACCOUNTING ||
      runType == RT_RULE_ACCOUNTING)
  {
     ...
     _ui._supplyConvSeparator->show();
     _ui._supplyConvCheckBox->show();

     // TODO: get rid fo this _ui._supplyConvCheckBox, as it's now obsolete
     _ui._supplyConvCheckBox->setChecked(true);
  }

  // ********************************
  // *** Checkbox Toggle Handling ***
  // ********************************

  connect (_ui._supplyConvCheckBox, SIGNAL (toggled (bool)),
           SLOT (supplyConvHandler (bool)));

  // private slot, virtual
  void QtSimParamDlg::supplyConvHandler(bool on)
  {
      on; // (avoid compilation warning)

      // TODO: get rid of  this supplyConvHandler, as the
      // functionality is now obsolete.
  #if 0
      AccountMgrObj->setSupplyConvergenceType(
          on ? NOCONVERGE : PERCENTCHANGE,
          on ? 0.0 : DEFAULTCONVERGENCE);
  #endif
  }

---