RiverWare 6.4 Develeopment Files using Qt3 compatibility methods -- May 2013

RiverWare 6.4 Development Files using Qt3 compatibility methods

This presents an estimate of the number of C++ files containing code using Qt3 compatibility methods, and -- roughly -- the total number of items in those files. This was done by heuristically searching RiverWare source for a representative subset of those methods.

Summary:

198 C++ files contain calls to Qt3 compatibility methods
Those files contain 2991 calls to the sample subset of methods.
... about 15 items per file, on average.

I would guess that there are maybe twice as many actual calls to such methods, but the number of files to be processed (about 200) is pretty accurate.

Notes:

QActions represent a large number of the required changes. Note that the need to change the 'activated' signal to 'triggered' doesn't show up during compilation -- it shows up during execution when connecting those signals.
Removal of use of the Qt3 compatibility library is done by adding the following directive to the head of each .cpp file (before all the header file includes) and compiling -- and in the case of Qt signal changes -- running and watching for warnings reported to the console.
- // Prevent use of the Qt3 compatibility library
  #undef QT3_SUPPORT

Analysis Count Details:

	Sample Qt3 compatibility method call	call count
1	QAction construction	654
2	QHBoxLayout and QVBoxLayout construction	117
3	QPushButton construction	134
4	QLabel construction	131
5	QLineEdit construction	21
6	QComboBox construction	27
7	QSpinBox construction	2
8	QFrame construction	63
9	QWidget construction	22
10	QButton setPixmap()	100
11	QAction activated() signal connection	828
12	QAction isOn()	228
13	QAction setToggleAction()	110
14	setShown()	221
15	setActiveWindow()	152
16	QComboBox *urrentItem()	129
17	close (bool)	62
Total call count:		2991

File List -- RiverWare .cpp files (198) containing calls to Qt3 compatibility methods:

DbDmi/DatasetCfgWidget.cpp
DbDmi/DatasetDlg.Btn.cpp
DbDmi/DatasetDlg.Cfg.cpp
DbDmi/DatasetDlg.Name.cpp
DbDmi/DbDmiDlg.cpp
DbDmi/DbDmiEditDlg.Delegate.cpp
DbDmi/DbDmiEditDlg.cpp
DbDmi/DbDmiImpExpDlg.cpp
DbDmi/DbDmiMgr.Diag.cpp
DbDmi/DssDataTypesDlg.cpp
DbDmi/DssDatasetDlg.cpp
DbDmi/ExcelDatasetDlg.cpp
DbDmi/HdbModelRunIdEditDlg.cpp
DbDmi/NameMapDlg.cpp

Q3GUI/AboutDlg.cpp
Q3GUI/AccountGroupDlg.cpp
Q3GUI/AcctOrderPanel.cpp
Q3GUI/AcctOrderTreeWidget.cpp
Q3GUI/AcctOrderTreeWidgetItem.cpp
Q3GUI/AdjustSlotValsDlg.cpp
Q3GUI/AnnoGroupEditor.cpp
Q3GUI/AnnoGroupMgrDlg.cpp
Q3GUI/AxisDlg.cpp
Q3GUI/BaseQtDlg.cpp
Q3GUI/BaseQtMainWin.cpp
Q3GUI/ChartDlg.cpp
~~Q3GUI/ColorChooser.cpp~~
Q3GUI/ConfigSlotsDlg.cpp
Q3GUI/CurveDlg.cpp
Q3GUI/DiagCfgDlg.Panel.cpp
Q3GUI/DiagCfgDlg.cpp
Q3GUI/DiagMgrDlg.cpp
Q3GUI/DiagMsgDataModel.cpp
Q3GUI/DiagOutputColorLegend.cpp
Q3GUI/DiagOutputDlgMgr.cpp
Q3GUI/DiagOutputDockWindow.cpp
Q3GUI/DiagOutputMenuItems.cpp
Q3GUI/DiagOutputQMainWindow.cpp
Q3GUI/DiagOutputWidget.cpp
Q3GUI/DmiMenuItems.cpp
Q3GUI/ExportImageDlg.cpp
Q3GUI/FileInfoDlg.cpp
Q3GUI/FileTypeAssocMgrDlg.cpp
Q3GUI/FloatValueEditor.cpp
Q3GUI/GeoCanvasConfigDlg.cpp
Q3GUI/GreenBookConfigPanel.cpp
Q3GUI/GridDlg.cpp
Q3GUI/GusDialog.cpp
Q3GUI/GusFilter.cpp
Q3GUI/GusFilterControl.cpp
Q3GUI/GusOptionDisplayControl.cpp
Q3GUI/GusPanel.Account.cpp
Q3GUI/GusPanel.SimObj.cpp
Q3GUI/GusPanel.cpp
Q3GUI/GusSelector.cpp
Q3GUI/ImpExpWorkspaceDlg.cpp
Q3GUI/LinkEditorDlg.cpp
Q3GUI/LinkGroupDlg.cpp
Q3GUI/ListSlotDlg.cpp
Q3GUI/LoadSaveMgr.cpp
Q3GUI/MarkerDlg.cpp
Q3GUI/ModelReportConfigDlg.cpp
Q3GUI/ModelReportSettingTree.cpp
Q3GUI/MultiObjMethObjListView.cpp
Q3GUI/MultiObjMethSelConfirmDlg.cpp
Q3GUI/MultiObjMethSelector.cpp
Q3GUI/NoteGroupMgrDlg.cpp
Q3GUI/NumDisplayAttribsPanel.cpp
Q3GUI/ObjectGroupDlg.cpp
Q3GUI/OpenObjectDlg.cpp
Q3GUI/OutputConfigDlg.cpp
Q3GUI/OutputManager.cpp
Q3GUI/PeriodTimeSelector.cpp
Q3GUI/PeriodicSlotCfg.cpp
Q3GUI/PlotDialog.cpp
Q3GUI/PlotDialog.qt.cpp
Q3GUI/PlotDlgSettings.cpp
Q3GUI/PlotPageLayoutButtons.cpp
Q3GUI/PlotPageSelPanel.cpp
Q3GUI/PropagateDlg.cpp
Q3GUI/QGui.cpp
Q3GUI/RwNoticeBox.cpp
Q3GUI/RwQtUtils.cpp
Q3GUI/ScalarSlotDlg.cpp
Q3GUI/ScenarioMgrDlg.cpp
Q3GUI/ScenarioMgrWids.cpp
Q3GUI/ScenarioSandboxDlg.cpp
Q3GUI/ScenarioSlotTreeWidget.cpp
Q3GUI/SimilarPlotsDlg.cpp
Q3GUI/SlotConfigQtDlg.cpp
Q3GUI/SlotDataTableModel.cpp
Q3GUI/SlotPlot.cpp
Q3GUI/SlotQtDlg.cpp
Q3GUI/SlotScaleSliderPanel.cpp
Q3GUI/SlotSetOutputConfigDlg.cpp
Q3GUI/SlotTimeseriesRangeQtDlg.cpp
Q3GUI/SnapMgrObjListView.cpp
Q3GUI/SnapMgrSlotListView.cpp
Q3GUI/SnapshotMgrDlg.cpp
Q3GUI/StatTableSlotDlg.cpp
Q3GUI/SubbasinMgrDlg.cpp
Q3GUI/SupplyGroupDlg.cpp
Q3GUI/TimeStepSelListView.cpp
Q3GUI/TimeStepSelPanel.cpp
Q3GUI/UnitConvertDlg.cpp
Q3GUI/Workspace.cpp
Q3GUI/WorkspaceTreeWidget.cpp

QtAccounting/AccountMgrDlg.cpp
QtAccounting/AccountSelectGroupBox.cpp
QtAccounting/AccountingSysConfigDlg.cpp
QtAccounting/AcctCellColorLegend.cpp
QtAccounting/AcctSubordinationViewerDlg.cpp
QtAccounting/ExchangeCfgDlg.cpp
QtAccounting/ExchangeMgrDlg.cpp
QtAccounting/ObjAcctSumSaveDlg.cpp
QtAccounting/ObjAcctSumSel.cpp
QtAccounting/OpenAccountDlg.cpp
QtAccounting/QtAcctGuiMgr.cpp
QtAccounting/QtAcctUtils.cpp
QtAccounting/SupplyEditor.cpp
QtAccounting/SupplyMgrDlg.cpp
QtAccounting/SupplyNameFormatDlg.cpp

QtDmi/DmiEditorDlg.cpp
QtDmi/DmiHandlerDlg.cpp
QtDmi/DmiMgrDlg.cpp
QtDmi/DmiParamDlg.cpp
QtDmi/DmiParamTreeView.cpp
QtRpl/RowOToggles.cpp
QtRpl/RplAnalysisDlg.cpp
QtRpl/RplBaseDlg.cpp
QtRpl/RplBlockDlg.cpp
QtRpl/RplDisplaySettingsDlg.cpp
QtRpl/RplDlgMgr.cpp
QtRpl/RplDocConfigDlg.cpp
QtRpl/RplExpressionMenu.cpp
QtRpl/RplFrame.cpp
QtRpl/RplFunctionDlg.cpp
QtRpl/RplGroupDlg.cpp
QtRpl/RplObjView.cpp
QtRpl/RplPaletteDlg.cpp
QtRpl/RplPolicyMenu.cpp
QtRpl/RplSearchReplaceDlg.cpp
QtRpl/RplSetDlg.cpp
QtRpl/RplTypeComboBox.cpp
QtRun/DistribPanel.cpp
QtRun/MrmDmiTreeView.cpp
QtRun/MrmPolicyTreeView.cpp
QtRun/MrmRunTreeView.cpp
QtRun/MultiRunControlDlg.cpp
QtRun/MultiRunEditDlg.cpp
QtRun/QtOptParamSubDlg.cpp
QtRun/QtRunControlDlg.cpp
QtRun/QtRunStatusDlg.cpp
QtRun/QtRunSyncDlg.cpp
QtRun/QtSimParamDlg.cpp
QtRun/SimObjDispatchStateButton.cpp
QtRun/SyncControlDlg.cpp
QtRun/USACEMethodsDetailsWidget.cpp

QtSCT/SctDialog.StatusBar.cpp
QtSCT/SctDialog.cpp
QtSCT/SctSetSumFuncDlg.cpp
QtSCT/SctTimestepAggCfgDlg.cpp

QtUtils/BgImageConfigDlg.cpp
QtUtils/BoilerTreeView.cpp
QtUtils/CustomTimeRangeEditorDlg.cpp
QtUtils/DataSelectionStatusFrame.cpp
QtUtils/DisplayCompressPanel.cpp
QtUtils/ExprSlotTreeInspectorDlg.cpp
QtUtils/FindSlotsWithInputsDlg.cpp
QtUtils/GenListView.Item.cpp
QtUtils/GenListView.cpp
QtUtils/GriddedObjDataEditDlg.cpp
QtUtils/GriddedObjDataTable.cpp
QtUtils/MassBalSumDependPanel.cpp
QtUtils/MassBalSummaryDlg.cpp
QtUtils/ObjCoordMgrDlg.cpp
QtUtils/ObjCoordMgrTable.cpp
QtUtils/PartialDateTimeEditor.cpp
QtUtils/RunButtonFrame.cpp
QtUtils/RunParamFrame.cpp
QtUtils/RwGraphicsScene.cpp
QtUtils/RwGraphicsView.cpp
QtUtils/SaveModelConfirmDlg.cpp
QtUtils/SlotIdPanel.cpp
QtUtils/SlotListPanel.cpp
QtUtils/SlotQTreeWidget.cpp
QtUtils/TimestepComboBox.cpp
QtUtils/UnitSchemeMgrDlg.cpp
QtUtils/WorkspaceGfxScene.cpp

Sim/PeriodicSlot.DMI.cpp
Sim/RootFilter.cpp
Sim/RootSel.tab.cpp
Sim/ScalarSlot.DMI.cpp
Sim/SelectionPartBase.cpp
Sim/SeriesSlot.DMI.cpp
Sim/SimWS.cpp
Sim/Slot.cpp
Sim/TableSlot.DMI.cpp
---