CADSWES, 12-03-2011

Gnats 5130: RiverWare 6.0 to 6.1: Loss of Account graphic item order.
http://cadswes2.colorado.edu/users/cgi-bin/gnats-query-single.pl?Number=5130

A fix has been applied to preserve the order of Account graphics items (in
the Accounting Workspace) when loaded from the prior version of
RiverWare.  The problem was with the set of Accounts on Element Objects
within an Aggregate Object (e.g. an Aggregate Reach).

There is still a limitation in the persistence of the order of Accounts
among the Element Objects of an Aggregate Object. (This limitation existed
also in RiverWare 6.0).  The Accounts within each Element object will
always be grouped together (upon reloading a model), in the order of the
Elements within the Aggregate Object, regardless of the item order which
had been set by the user (by dragging Account graphic items).

We'll need to decide when to address this latter limitation, i.e. possibly
not in the initial 6.1 release.  The implemented fix (see above) does
address the '6.0 to 6.1' migration bug originally reported.

TECHNICAL ... In method: AccountTable::addAccount (Account*, SimObj*), the
Account's display position property is initialized if it doesn't have a
positive value.  It had been set to the number of accounts already in the
SimObj (plus one).

But, in the case of Accounts on Aggregate Objects and their Element
Objects, the display positions of Accounts need to be relative to ALL of
the Accounts under the top-level Aggregate Object.  This is because
graphics items for Accounts in the Accounting Workspace are organized
within a SimObj rectangle corresponding to the top-level Object (or
Aggregate Object).

The fix was applied to both the 6.1 and 6.2 repositories. Changes in
files: Accounting/AccountTable.cpp .. Sim/SimObj.hpp ..
Sim/SimObj.Acct.cpp.

---