Short Description: Change availability of Slot Config Dialogs/Operations Bug Number: 4980 Release notes (y/n): Yes For Release Nums: 5.3 Gnats 4980: Configure menu in new expression slot is disabled SEE http://cadswes2.colorado.edu/~philw/2010/bugs/4980/ ALSO: Removal of some Flag-setter menu items in the SCT (see bottom). Re-implementation of the "availability" of Slot Configuration and Time Series Range dialogs from Open Slot Dialogs. The major criteria have been centralized in these Sim/SlotGUIUtils functions: bool dataEditable (const Slot*); bool dispPropsEditable (const Slot*); // display units, precision, format bool execPropsEditable (const Slot*); // convergence, min/max, series range One major change is that changing "Display" properties (e.g. display precision or units) is now possible for non-editable Slots (with some limitations) -- in Viewer Mode, or slots on Data Objects or Non-Scenario Slots in Baseline Models. When showing a Slot Configuration in these cases, the following limitations apply: (1) When changing Units (always within the same Unit Type), there is no option for "No Conversion". Values are always "converted" (which means that the underlying Standard Unit values are NOT changed). (2) In multiple-column Slots, only one column can be configured at a time. This was sufficient for avoiding "nailing" the Unit TYPE of columns on these read-only Slots. (A more precise policy could be coded, but this, at least, is safe). -------------------- Sim/SlotGUIUtils.hpp Sim/SlotGUIUtils.cpp -------------------- Old function removed: bool isEditable (const Slot*); .. Replaced with: bool dataEditable (const Slot*); bool dispPropsEditable (const Slot*); // display units, precision, format bool execPropsEditable (const Slot*); // convergence, min/max, series range See details at http://cadswes2.colorado.edu/~philw/2010/bugs/4980/ -- also summarized here: // ============================================= // Data Editable? // // (1) NO -- Slots with RPL Expressions // (2) NO -- Slots on Snapshot Objects // (3) YES -- Other Slots // (4) NO -- Viewer Mode // (5) NO -- Non-Scenario Slots in Baseline Model // ============================================= // ============================================= // Display Properties Editable? // ... display units, precision, format. // // (1) YES -- Slots with RPL Expressions // (2) YES -- Slots on Snapshot Objects // (3) YES -- Other Slots // (4) YES -- Viewer Mode // (5) YES -- Non-Scenario Slots in Baseline Model // ============================================= // ============================================= // "Execution" Properties Editable? // ... convergence, min/max, series range // // (1) YES -- Slots with RPL Expressions // (2) NO -- Slots on Snapshot Objects // (3) YES -- Other Slots // (4) NO -- Viewer Mode // (5) NO -- Non-Scenario Slots in Baseline Model // ============================================= ----------------------- Q3GUI/SlotQDlgTable.cpp Q3GUI/SlotQtDlg.cpp ----------------------- (1) Client modifications for Sim/SlotGUIUtils function changes. (2) Don't refrain from showing the Slot Configuration and Time Series Range dialogs only because the slot data is not editable. Disabling of operations is handled IN those two dialog boxes. -------------------------- Q3GUI/ScalarSlotCfgDlg.hpp Q3GUI/ScalarSlotCfgDlg.cpp -------------------------- Added method: updateEditability(); ------------------------- Q3GUI/SlotConfigQtDlg.hpp Q3GUI/SlotConfigQtDlg.cpp ------------------------- Added method: updateEditability(); Removed flag -- this is now computed dynamically: bool _editModeEnabled; ---------------------------------- Q3GUI/SlotTimeseriesRangeQtDlg.hpp Q3GUI/SlotTimeseriesRangeQtDlg.cpp ---------------------------------- Added method: updateEditability(); ---------------------------- QtSCT/SctConfigWidgets.ui QtSCT/SctDialog.Handlers.cpp QtSCT/SctDialog.cpp QtSCT/SctDialog.hpp QtSCT/SctModelData.Sim.cpp ---------------------------- Removal of MENU ITEMS for setting the "Surcharge Release" and "Regulation Discharge" flags. Those flags, like the "Set by Rules" flag, are now "display only" flags. Toolbar BUTTONS for all three of those flags are among those that can optionally be shown -- but those buttons are never enabled. They function as a "color key" to show the user-configurable colors for those Flags. Removed: QAction* _setSurchargeRelAction; QAction* _setRegDischargeAction; void setSurchargeRel_Handler(); void setRegDischarge_Handler(); Change in method: bool SctModelData::flagCanBeSetOnSeriesSlot (SeriesSlot*, char flagCh) Also: Client modifications for Sim/SlotGUIUtils function changes. ---