Plot Templates (RiverWare 5.3) -- David's Second Review (8-19-2010) ... See First Review
Edit: 8-23-2010, Phil's comments regarding problem resolution ... See Prior Screenshots.

Item Resolved Resolution Status
3 --- No change recommended.
4 --- No change recommended.
10  8-19-2010  Fixed, as Gnats 4935. Apply to Prerel too?
13  8-20-2010  Done, minor text change.
14  8-20-2010 

Fixed, but only if the user chooses to generate Plot Pages with the new checkbox checked:
 [X] Recompute Axis Titles (to show correct axis units for substituted slots) 

15 8-23-2010 Fixed, as fixup in SlotPlot::setAxes (SlotCurve*).

David's General Comments (8-19-2010):

3 [8-12-2010]: Clicking the button "Create Plot from Template" should just go to the plot (-dialog), not the (configure-) plot page dialog. I think the user would rather see the plot first, then they can save it from there. The "Plot Page" dialog doesn't add much and seems an unnecessary step. In fact, to go from the output manager with a plot template to actually seeing the plot, you go through 3 dialogs, OutputManager->Plot Page Template->Plot Page-> plot. We should at least close some along the way. Also, when you click "Create Plot from Template" it saves the plot. Is this desired behavior? Do we really want to save the generated plots?
 

[8-17-2010]: Addressed. This operation (the "Create Plot Page From Template" button at the bottom of this dialog) was changed. It now brings up the Plot dialog, and optionally also shows a "Save As" dialog (to save the new Plot Page) IF the added checkbox was checked: [X] Save new Plot Page to Output Manager.

[8-19-2010]: Why do we need to go to the "Save as" dialog. Can't we just have a inline editor on the "create Plot from template" dialog where we can enter a new name? This toggle should be above the "Create..." buttons in the dialog and left-justified.
  I think that the implemented solution is better. And it is consistent with the original spec. With the current implementation, the user gets to see BOTH the generated plot page AND the list of previously saved plot pages when choosing a name to use for saving the new generated plot page. It also has the advantage of being consistent with how Plot Pages are saved -- both in terms of user interface and implementation.
4 [8-12-2010]: BUG: in the Output Manager, highlight a template and click Copy->Selected you get a crash.
  [8-17-2010]: Fixed.
[8-19-2010]: [In the Output Manager,] Copy->Selected doesn't crash anymore, but if you just have a template highlighted Copy->Selected is not enabled. If you have a template and a plot highlighted and select Copy->Selected, it copies both just fine. Can we enable Copy->Selected for templates?
  At this time, there is no purpose for copying a Plot Page Template, because there isn't anything editable within the Plot Page Template dialog (except now, the name). Having additional copies of a Plot Page Template doesn't provide any benefit. However, if and when we add editing of Plot Page Template properties in that dialog, the Copy->Selected operation should be enabled for Plot Page Templates in the Output Manager.
10 [8-12-2010]: Saving a Supply to a template does not work. In the Save Plot Page as Template, the supplies are missing. Exchange slots too.
  [8-17-2010]: Fixed for Supplies. As per the original requirements statement, substitutions for Exchanges or Exchange Slots are not supported.
[8-19-2010]: Supplies still don't work. I think there is some other issue in saving a plot that has supplies and particularly saving/reloading the model. I can show you if you don't see this.
 

Fixed. This turned out to be a bug in the creation of Plots from an Open Slot Dialog for an Account Multislot showing Subslots (which are linked to Supplies). See Gnats 4935: Incorrect treatment of Supply Slot names in Plot Pages, "__dot__".   See also these two images.

13 [8-19-2010]: Copy/Paste of graphs. "Overwriting Non-Empty Graph" confirmation buttons should say "OK" and "Cancel" not "Overwrite" and "Cancel". [SEE IMAGE].
  Changed.
14 [8-19-2010]: If you create a template with a Slot, say Storage (acre-ft). Then you generate a plot and choose a slot with different units, say Outflow. The new axis is mislabeled, saying cfs. I know that we don't let them edit axis labels yet, but this seems misleading.
 

Fixed, but only if the user chooses to generate Plot Pages with the new checkbox checked:
 [X] Recompute Axis Titles (to show correct axis units for substituted slots) 


See Full Dialog.

15 [8-19-2010]: If a plot generated from a template has a completely different type of X axis, it seems to have problems. If the template is for a statistical table slot, but then you choose to generate a periodic slot, the plot is blank. Or from a prob scale to a linear scale, same blank plot.
  Fixed.  Fixup for slot substitution resulting in an incompatibility between an Axis Type (in particular, Probability Scale) and Axis Units (in particular, anything other than "percent"). The fix is in method: SlotPlot::setAxes (SlotCurve*). See new method: SlotPlot::checkAxisTypeUnitConformity (int axis, const QString& unitStr).

---