Open Object Dialog Qt4 Port and Enhancements: Post-Development Review One
Responses to Mitch's first review: 1-18-2013 email / See "Review Two" (David).
Phil, original draft: 1-22-2013 / updated: 1-23-2013 (Point #5).
1 | First, I really like the filtering and ordering on the Slots tab. The ordering functionality is much more intuitive now. The filtering is very easy to use, and the option to hide all empty, unlinked series slots is very useful and convenient. | |
2 | On the Methods tab the ordering functionality does not appear to be working correctly. When I first open the dialog and go to the methods tab it has the default order. If I click on the Restore Default Order button, it lists the methods in reverse alphabetical order then becomes disabled. I can then click on the column header and it reverses to alphabetical order. Then clicking on the Restore Default Order button does nothing, and it becomes disabled again. After clicking on Restore Default Order (making it disabled), clicking on the column header does nothing except re-enable the Restore Default Order button. Then clicking on the column header will reverse the current sorting (alphabetically). Also after the initial opening of the dialog, clicking on the column header (in the Methods tab) does nothing.
In short, the Restore Default Order button on the Methods tab does not appear to be doing what it is intended to do, and clicking on the column header does not always sort the list alphabetically or reverse the order. |
|
DONE. These problems have been addressed. | ||
3 | One other note on the alphabetical sorting in the Methods tab, it first sorts all categories / methods beginning with capital letters. It then sorts the names beginning with lower case letters separately. | |
DONE. List (TreeWidget) item sorting is now case insensitive. | ||
4 | I was wondering if there was a reason that the Methods tab does not have up/down arrows to reorder the categories. It might be nice, though not hugely important, to put only methods in use at the top then save as a custom order like the slots. | |
This would be an enhancement. It would require persistance of custom category orders for objects and/or object types. This is beyond the scope of this current work. | ||
5 | On the Slots tab Order menu, it might be easier to understand if the options were:
... and similarly for the Save As options. This is not a big deal, and it would only take a user one time to figure out what these mean, but it is not entirely obvious at first. A quick look in the Online Help should be able to clear up any confusion. |
|
UPDATE [1-23-2013]: We made this text change WITH the reimplementation of the Slot Order combo box using a discrete popup menu in place of the combo box's "native" popup. This was in the original design, but was initially implemented with just a plain QComboBox. This reimplementation now allows the combo box to be no wider than it needs to be for the five actual order modes. The "one-shot" "Save as" operations (needed only in the popup -- not in the actual combo box) no longer contribute to the width of the combo box. Here is the prior version: |
||
6 | ... Slots tab: If the status of a slot changes (e.g. unlinked to linked) the change in regards to the empty and unlinked slots filter does not show up until the object dialog is closed and re-opened (or the filter is re-applied directly). Also, if a link is deleted, the linked icon in the slot list still shows that the slot is linked until the object dialog is re-opened. I assume that the filter is being applied when the object is opened. I can't imagine this really creating a problem for a user. ... | |
This was partially addressed, as an enhancement. It turns out that the prior Qt3 implementation (e.g. in RiverWare 6.2) didn't support dynamic updating of the "[L]" icons on the slot items. New callbacks were added to support dynamic updating of both those icons AND the "Hide empty un-linked series slots" list. However, updating of the "Hide empty un-linked series slots" in response to slot value changes is not fully automatic, for performance reasons. To accommodate this, a "Refresh" button is shown when that special hiding mode is active -- with a tooltip providing information about the slots hidden as part of "empty un-linked" hiding. (See below). Updates occur also as a result of most other user operations, e.g. turning the filter off and on. |
--- (end) ---